Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update init gas price #3383

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: Update init gas price #3383

merged 1 commit into from
Dec 19, 2024
+1 −1

Conversation

piux2
Copy link
Contributor

@piux2 piux2 commented Dec 19, 2024 •
edited
Loading

The number is too large due to the increased gas configurations. This change will reduce the cost from 1 gnot to 0.01 gnot for a transaction that uses 10 million gas.

@piux2
fix: Update init gas price
a13adf7 
the number is too big as we increased gas configurations.
@piux2 piux2 requested a review from zivkovicmilos December 19, 2024 20:12
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 19, 2024
@piux2 piux2 requested a review from wyhaines December 19, 2024 20:12
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

wyhaines
wyhaines approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@wyhaines wyhaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will make the fees easier to reason about, and just superficially feel like they make more sense and will feel better to users. It looks good to me.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@piux2 piux2 merged commit 329845f into master Dec 19, 2024
115 checks passed
@piux2 piux2 deleted the piux2-patch-1 branch December 19, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@wyhaines wyhaines wyhaines approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

Assignees

@piux2 piux2

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piux2 @Gno2D2 @wyhaines @moul